Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

909 Drop deprecated APIs in IO transforms #1448

Merged
merged 6 commits into from
Jan 14, 2021
Merged

909 Drop deprecated APIs in IO transforms #1448

merged 6 commits into from
Jan 14, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jan 14, 2021 •
edited
Loading

Partly fixes ticket 909 .

Description

As part of task #909 , this PR droped the deprecated APIs in IO transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 2 commits January 14, 2021 10:57
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 14, 2021

/black

@Nic-Ma Nic-Ma marked this pull request as ready for review January 14, 2021 10:01
@Nic-Ma Nic-Ma changed the title [WIP] 909 Drop deprecated APIs in IO transforms 909 Drop deprecated APIs in IO transforms Jan 14, 2021
@Nic-Ma
[DLMED] fix typo
db31dbd 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 909-drop-old-dataloaders branch from 42dcb99 to db31dbd Compare January 14, 2021 10:05
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 14, 2021

/black

Nic-Ma added 2 commits January 14, 2021 18:11
@Nic-Ma
[DLMED] fix flake8 issue
1091f2b 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] remove unused import
2abddf2 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 14, 2021 •
edited by wyli
Loading

/black

wyli
wyli approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 8084394 into Project-MONAI:master Jan 14, 2021
@rijobro rijobro mentioned this pull request Jan 21, 2021
Closed
@Nic-Ma Nic-Ma deleted the 909-drop-old-dataloaders branch July 2, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nic-Ma @wyli