Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1534 type hints numpy 1 20 #1536

Merged
merged 7 commits into from
Feb 2, 2021
Merged

1534 type hints numpy 1 20 #1536

merged 7 commits into from
Feb 2, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 1, 2021 •
edited
Loading

Fixes #1534

Description

non-breaking changes to fix the type check issues

mainly relaxing the type constraints, referring to

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.

wyli added 4 commits February 1, 2021 18:39
@wyli
numpy dtype alias
03665d6 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
is_tensor => isinstance
fee05b8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
type of dtype
25a0aa2 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
relaxes some typing contraints
9115b74 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Feb 1, 2021 •
edited
Loading

/black
/integration-test

@wyli wyli requested review from Nic-Ma, rijobro and ericspod February 1, 2021 21:50
@wyli wyli marked this pull request as ready for review February 1, 2021 21:51
@wyli wyli force-pushed the 1534-type-hints-np-1-20 branch from 385773e to cd500e9 Compare February 1, 2021 22:17
@wyli
fixes unit tests
e729136 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 1534-type-hints-np-1-20 branch from cd500e9 to e729136 Compare February 1, 2021 22:37
Nic-Ma
Nic-Ma approved these changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Thanks for your quick fix for all the new type hints issues.
Looks good to me except for several minor comments.

Thanks.

monai/networks/nets/regressor.py Outdated Show resolved Hide resolved
monai/transforms/croppad/array.py Show resolved Hide resolved
monai/transforms/intensity/array.py Show resolved Hide resolved
wyli added 2 commits February 2, 2021 08:09
@wyli
update based on the comments
bfc211b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes docstring typos
b8754ce 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli merged commit c415509 into Project-MONAI:master Feb 2, 2021
@wyli wyli mentioned this pull request Mar 26, 2021
Closed
@wyli wyli deleted the 1534-type-hints-np-1-20 branch April 28, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

static type checks fail since numpy 1.20
2 participants
@wyli @Nic-Ma