Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1525 add MultiScaleLoss #1544

Merged
merged 4 commits into from
Feb 4, 2021

Conversation

kate-sann5100
Copy link
Collaborator

@kate-sann5100 kate-sann5100 commented Feb 3, 2021

Signed-off-by: kate-sann5100 yiwen.li@st-annes.ox.ac.uk

Fixes #1525.

Description

Add MultiScaleLoss

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! please see a few comments inline

monai/losses/multi_scale.py Outdated Show resolved Hide resolved
monai/losses/multi_scale.py Outdated Show resolved Hide resolved
monai/losses/multi_scale.py Outdated Show resolved Hide resolved
Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 2021f24 into Project-MONAI:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiscale segmentation loss API
2 participants