Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1542 Add RandLambdad transform #1546

Merged
merged 11 commits into from
Feb 4, 2021
Merged

1542 Add RandLambdad transform #1546

merged 11 commits into from
Feb 4, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 4, 2021

Fixes #1542 .

Description

This PR added RandLambdad transform to support CacheDataset for random lambda function.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 4 commits February 1, 2021 19:15
@Nic-Ma
Merge pull request #19 from Project-MONAI/master
42a45e0 
merge master
@Nic-Ma
Merge pull request #23 from Project-MONAI/master
b55bb8d 
merge master
@Nic-Ma
[DLMED] add RandLambdad transform
94d25f7 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add doc-strings
8394882 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 4, 2021

/black

wyli
wyli reviewed Feb 4, 2021
View reviewed changes
tests/test_rand_lambdad.py Outdated Show resolved Hide resolved
monai-bot and others added 2 commits February 4, 2021 12:51
@monai-bot
[MONAI] python code formatting
b65fe93 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma
[DLMED] update according to comments
d418a21 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 4, 2021

/black

@Nic-Ma
[DLMED] fix typo
3c0a297 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 1542-add-randlambda branch from f10fca7 to 3c0a297 Compare February 4, 2021 14:31
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 4, 2021

/black

@Nic-Ma
[DLMED] change to rtol=1e-05
2c2c0e1 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 1542-add-randlambda branch from 9491af8 to 2c2c0e1 Compare February 4, 2021 15:16
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 4, 2021

/black

monai-bot and others added 2 commits February 4, 2021 15:19
@monai-bot
[MONAI] python code formatting
b98f016 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@wyli
fixes seeds
93a08d5 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 1542-add-randlambda branch from 7670055 to 93a08d5 Compare February 4, 2021 17:51
@wyli wyli merged commit bcdee8c into Project-MONAI:master Feb 4, 2021
@Nic-Ma Nic-Ma deleted the 1542-add-randlambda branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rijobro rijobro rijobro approved these changes

@wyli wyli wyli approved these changes

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lambda transform should be optionally randomisable
4 participants
@Nic-Ma @wyli @rijobro @monai-bot