Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deepgrow training transforms #1579

Merged
merged 10 commits into from
Feb 22, 2021
Merged

Add deepgrow training transforms #1579

merged 10 commits into from
Feb 22, 2021

Conversation

YuanTingHsieh
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh commented Feb 12, 2021 •
edited
Loading

Description

Add deepgrow training related transforms
This PR is part of the original PR (#1395) with updated tests and docstrings

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@YuanTingHsieh
Add DeepGrow 2D/3D transforms
f1550e4 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@YuanTingHsieh
Fix docstrings
f7318f6 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@YuanTingHsieh
Remove inference transform for smaller PR
ef748ce 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@YuanTingHsieh
Remove unused imports
48c5744 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@YuanTingHsieh YuanTingHsieh changed the title [WIP] Add deepgrow training transforms Add deepgrow training transforms Feb 12, 2021
@SachidanandAlle
Copy link
Contributor

LGTM, we can add the reference of original PR #1395 in the description and assign to MONAI developers for final review

ericspod
ericspod reviewed Feb 16, 2021
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments that are pretty minor.

@YuanTingHsieh
Fix review comments
45e8a8b 
Signed-off-by: YuanTingHsieh <yuantinghsieh@gmail.com>
@YuanTingHsieh
Copy link
Collaborator Author

Thanks for the feedback!
I have fixed those issues.

wyli
wyli reviewed Feb 19, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks please see some comments inline

monai/apps/deepgrow/transforms.py Show resolved Hide resolved
monai/apps/deepgrow/transforms.py Show resolved Hide resolved
monai/apps/deepgrow/transforms.py Outdated Show resolved Hide resolved
@wyli wyli mentioned this pull request Feb 20, 2021
Closed
7 tasks
@wyli
Copy link
Contributor

wyli commented Feb 22, 2021

/black

@wyli wyli enabled auto-merge (squash) February 22, 2021 14:50
wyli
wyli approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please update the relevant tutorial

@wyli wyli merged commit 46cc0e5 into Project-MONAI:master Feb 22, 2021
@YuanTingHsieh YuanTingHsieh deleted the add_deepgrow_transforms branch February 27, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod left review comments

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YuanTingHsieh @SachidanandAlle @wyli @ericspod