Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1568 Enhance tests to use self random state #1599

Merged
merged 10 commits into from
Feb 21, 2021
Merged

1568 Enhance tests to use self random state #1599

merged 10 commits into from
Feb 21, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 19, 2021

Fixes #1568 .

Description

This PR enhances the 3D and 2D random images in tests to use an independent random state.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 19, 2021

/black

@monai-bot
[MONAI] python code formatting
d462c6e 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@wyli
Copy link
Contributor

wyli commented Feb 19, 2021 •
edited
Loading

/integration-test

@Nic-Ma
[DLMED] fix CI tests
fcce892 
Signed-off-by: Nic Ma <nma@nvidia.com>
wyli
wyli previously approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@wyli wyli enabled auto-merge (squash) February 19, 2021 18:00
@wyli wyli dismissed their stale review February 19, 2021 18:15

there's a unit test broken

@Nic-Ma
[DLMED] fix CI test
7fb13c5 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix CI tests
103621c 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix CI tests
bbe0059 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Merge branch 'master' into 1568-test-random-state
22f7a6d
@Nic-Ma Nic-Ma requested a review from wyli February 20, 2021 15:33
@wyli wyli merged commit 181f633 into Project-MONAI:master Feb 21, 2021
wyli added a commit to wyli/MONAI that referenced this pull request Feb 21, 2021
@wyli
Revert "1568 Enhance tests to use self random state (Project-MONAI#1599…
2c8826f 
…)"

This reverts commit 181f633.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli mentioned this pull request Feb 21, 2021
Merged
1 task
Nic-Ma pushed a commit that referenced this pull request Feb 21, 2021
@wyli
Revert "1568 Enhance tests to use self random state (#1599)" (#1607)
19a9f05 
This reverts commit 181f633.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@Nic-Ma Nic-Ma deleted the 1568-test-random-state branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test cases should not change the global random states
3 participants
@Nic-Ma @wyli @monai-bot