Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1575 Add SaveImage and SaveImaged transforms #1612

Merged
merged 11 commits into from
Feb 23, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 22, 2021

Fixes #1575 .

Description

This PR added the SaveImage and SaveImaged transforms to save data in both pre-transforms and post-transforms.
This can be a useful debugging tool and output tool, like the existing DataStats transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 22, 2021

/black

Copy link
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 22, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 22, 2021 17:04
@Nic-Ma Nic-Ma disabled auto-merge February 22, 2021 17:04
monai/data/png_writer.py Outdated Show resolved Hide resolved
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 22, 2021

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@wyli wyli merged commit a664506 into Project-MONAI:master Feb 23, 2021
@Nic-Ma Nic-Ma deleted the 1575-add-saveimage branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SaveNifti transform to debug transform chain
4 participants