Skip to content

1633 fix string length > 1024 issue in all_gather #1634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 25, 2021
Merged

1633 fix string length > 1024 issue in all_gather #1634

merged 13 commits into from
Feb 25, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Feb 24, 2021

Fixes #1633 .

Description

This PR fixed the string list all gather issue when length > 2014. Changed to all_gather every item separately instead of joining to a long string.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 24, 2021

/black

@Nic-Ma Nic-Ma mentioned this pull request Feb 24, 2021
Closed
@Nic-Ma
[DLMED] fix flake8 issue
8c229d7 
Signed-off-by: Nic Ma <nma@nvidia.com>
wyli
wyli reviewed Feb 24, 2021
View reviewed changes
yiheng-wang-nv
yiheng-wang-nv approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nic, I did some test locally and it works fine.

@Nic-Ma
[DLMED] update according to comments
02dcbc6 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Merge branch 'master' into 1633-fix-str-allgather
2afda18
@Nic-Ma
[DLMED] update according to comments
67e695f 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add more test
b841875 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 25, 2021

/black

@wyli wyli enabled auto-merge (squash) February 25, 2021 15:07
monai-bot and others added 2 commits February 25, 2021 15:10
@monai-bot
[MONAI] python code formatting
c19d421 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma
[DLMED] fix flake8 issue
1980083 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Feb 25, 2021

Hi @wyli ,

The CI failed due to some CUDA driver missing issue, have you seen this before?

Thanks.

@wyli wyli merged commit 9ae3005 into Project-MONAI:master Feb 25, 2021
@Nic-Ma Nic-Ma deleted the 1633-fix-str-allgather branch July 2, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli left review comments

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@atbenmurray atbenmurray Awaiting requested review from atbenmurray

@ericspod ericspod Awaiting requested review from ericspod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MetricsSaver Bug when filename is long

4 participants

@Nic-Ma @wyli @yiheng-wang-nv @monai-bot