Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1979 Enhance TTA to align with Invertd args and support no label #2654

Merged
merged 6 commits into from
Jul 26, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jul 23, 2021

Fixes #1979 .

Description

This PR enhanced the TTA module to align with Invertd transform args and support the inference case without label, just set orig_key to the same as image_key.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 23, 2021

I will also update the TTA tutorial when this PR merged.

Thanks.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 23, 2021

/black

@Nic-Ma Nic-Ma requested review from rijobro, wyli and ericspod July 23, 2021 15:49
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, perhaps @rijobro could confirm this change

@Nic-Ma Nic-Ma merged commit 325775b into Project-MONAI:dev Jul 26, 2021
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jul 26, 2021

The funtion in the tutorial is:

tt_aug = TestTimeAugmentation(
    val_transforms,
    batch_size=5,
    num_workers=0,
    inferrer_fn=partial(infer_seg, model=model),  # fn to infer segmentation
    device=device
)

Seems no need to update.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestTimeAugmentation assumes label is present
2 participants