Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2749 Fix ThreadDataLoader reset #2750

Merged
merged 10 commits into from
Aug 13, 2021
Merged

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Aug 11, 2021

Fixes #2749 .

Description

This PR fixed the continuous run issue of ThreadDataLoader.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested a review from ericspod August 11, 2021 16:30
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 11, 2021

/black

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 11, 2021

Hi @ericspod ,

Could you please help review this PR?

Thanks in advance.

@madil90
Copy link
Contributor

madil90 commented Aug 12, 2021

/build

@Nic-Ma Nic-Ma requested review from wyli and rijobro August 12, 2021 02:08
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but @ericspod please confirm the usage. (the code comment line 91 is out of date in the current PR)

@Nic-Ma Nic-Ma requested a review from wyli August 13, 2021 02:38
monai/data/thread_buffer.py Outdated Show resolved Hide resolved
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 13, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) August 13, 2021 07:42
@Nic-Ma Nic-Ma merged commit 6f12e18 into Project-MONAI:dev Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreadDataLoader can't continuously run
4 participants