Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2707 Fill the outside of holes #2848

Merged
merged 7 commits into from
Aug 27, 2021
Merged

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Aug 26, 2021

Fixes #2707 .

Description

This PR is followup of #2707 according to the feature request from @finalelement , it will keep the selected holes and fill the outside with specified values.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 26, 2021

/black

@wyli
Copy link
Contributor

wyli commented Aug 26, 2021

Thanks, is there a paper reference for this? @Nic-Ma @finalelement

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 26, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 26, 2021

Thanks, is there a paper reference for this? @Nic-Ma @finalelement

Sure, I added the link in the latest commit.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) August 26, 2021 22:55
@Nic-Ma Nic-Ma merged commit f981ad0 into Project-MONAI:dev Aug 27, 2021
wyli added a commit to Borda/MONAI that referenced this pull request Aug 27, 2021
* [DLMED] add support to fill outside

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add paper link for cutout

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augmentation Transform | InCut & OutCut Dropping (ETA 08/27/21)
2 participants