Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 2849 Add cupy install as optional package #2855

Closed
wants to merge 5 commits into from

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Aug 27, 2021

Fixes #2849 .

Description

This PR added all the necessary info for cupy package.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 27, 2021

Hi @wyli ,

Seems we need to specify the CUDA version when installing cupy from wheel:
https://docs.cupy.dev/en/stable/install.html#installing-cupy
We can manually install cupy with specific CUDA version in CI config, but I am not clear how to support optional install with CUDA version?

Thanks.

@wyli
Copy link
Contributor

wyli commented Aug 27, 2021

we had discussions in #2131 as well, it's currently not resolved

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Aug 27, 2021

OK, I see.
@rijobro , I think we don't have a solution so far?

Thanks.

@rijobro
Copy link
Contributor

rijobro commented Aug 27, 2021

Thanks for linking the previous PR. So do any of our testing environments install cupy? Just want to confirm that we test our cupy code.

@Nic-Ma Nic-Ma closed this Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cupy missing from pip requirements
3 participants