Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2849 adds cupy to the testing environment #2858

Merged
merged 2 commits into from
Aug 27, 2021
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Aug 27, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #2849

Description

enable cupy in one of the gpu testing pipelines

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • In-line docstrings updated.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli mentioned this pull request Aug 27, 2021
7 tasks
@wyli wyli changed the title add cupy tests 2849 adds cupy tests Aug 27, 2021
@wyli wyli changed the title 2849 adds cupy tests 2849 adds cupy to the testing environment Aug 27, 2021
@wyli wyli requested review from Nic-Ma and rijobro August 27, 2021 09:54
@wyli wyli added the CI/CD label Aug 27, 2021
@wyli wyli requested a review from madil90 August 27, 2021 10:02
Copy link
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. We'll have to check through the logs to confirm that optional_import("cupy") is working and therefore the cupy unit tests are being performed. An easy place to check is test_to_cupy.py.

@wyli wyli merged commit aa5fa1d into Project-MONAI:dev Aug 27, 2021
@wyli
Copy link
Contributor Author

wyli commented Aug 27, 2021

Looks great. We'll have to check through the logs to confirm that optional_import("cupy") is working and therefore the cupy unit tests are being performed. An easy place to check is test_to_cupy.py.

sure, this is now tested, verified by the log https://github.com/Project-MONAI/MONAI/runs/3443271494?check_suite_focus=true (and the coverage report)

@wyli wyli deleted the add-cupy-tests branch August 27, 2021 13:50
wyli added a commit to Borda/MONAI that referenced this pull request Aug 27, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants