Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2701 Add dict version RandCoarseShuffle transform #2918

Merged
merged 8 commits into from
Sep 10, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Sep 9, 2021

Fixes #2701 .

Description

This PR added the dict version RandCoarseShuffled transform and fixed a random state-related error.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 9, 2021

/black

@madil90
Copy link
Contributor

madil90 commented Sep 9, 2021

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please confirm that the self.R call works fine in these dict-based transforms

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Sep 10, 2021

Hi @wyli ,

Thanks for your review.
Actually, in the dict version transform we don't use the self.R, we use the self.dropper or self.shuffle which is the array based random transform.
https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/intensity/dictionary.py#L1482

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) September 10, 2021 11:08
@Nic-Ma Nic-Ma merged commit e2965db into Project-MONAI:dev Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augmentation Transform | Patch Shuffling (ETA 8/27)
3 participants