Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dropout arg in DynUNet init #2947

Merged
merged 6 commits into from
Sep 13, 2021
Merged

Add dropout arg in DynUNet init #2947

merged 6 commits into from
Sep 13, 2021

Conversation

diazandr3s
Copy link
Contributor

@diazandr3s diazandr3s commented Sep 13, 2021 •
edited
Loading

Signed-off-by: Andres diazandr3s@gmail.com

Fixes #2946.

Description

Add dropout argument in init for DynUnet and DynUnetV1

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@diazandr3s
Add dropout arg in DynUNet init
bbb8008 
Signed-off-by: Andres <diazandr3s@gmail.com>
@diazandr3s diazandr3s requested a review from wyli September 13, 2021 20:29
@diazandr3s
Change to new API - dropout arg
73b8f7e 
Signed-off-by: Andres <diazandr3s@gmail.com>
@diazandr3s diazandr3s requested a review from wyli September 13, 2021 21:32
wyli
wyli approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for confirming, I'll add a quick test case and merge

wyli and others added 4 commits September 13, 2021 22:41
@wyli
add test cases
c71abe6 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@rijobro @wyli
ThresholdIntensity, ThresholdIntensityd (#2944)
536432f 
* ThresholdIntensity, ThresholdIntensityd

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@wyli
Merge branch 'dev' into AddDropoutDynUNet
298bd87
@wyli
fixes typing
6967929 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli enabled auto-merge (squash) September 13, 2021 21:47
@wyli wyli merged commit 01feacb into dev Sep 13, 2021
@wyli wyli deleted the AddDropoutDynUNet branch September 13, 2021 22:36
@diazandr3s diazandr3s mentioned this pull request Sep 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add dropout argument in init method in DynUNet
3 participants
@diazandr3s @wyli @rijobro