2948 Enhance the transform to delete items #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
|
/black |
|
There are potentially lots of meta tags per image, we'll need a better way to handle this, perhaps with a regular expression? |
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
force-pushed
the
2948-enhance-delete-items
branch
from
2f5d459 to
80e7a84
Compare
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
Hi @wyli , I have updated the PR to support nested dicts and regular expression according to your comments. Thanks in advance. |
wyli
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
looks good to me, (it introduces a minor style issue https://deepsource.io/gh/Project-MONAI/MONAI/run/7ffb3f4b-4c87-4ebf-a874-556df29c86b1/python/PYL-R1705)
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2948 .
Description
This PR enhanced
DeleteItemsdtransform to support recursive delete in dicts.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.