Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torch GaussianSmooth, RandGaussianSmooth, GaussianSharpen, RandGaussianSharpen #2971

Merged
merged 9 commits into from
Sep 24, 2021

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented Sep 17, 2021

Description

Torch GaussianSmooth, RandGaussianSmooth, GaussianSharpen, RandGaussianSharpen

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

…dGaussianSharpen`

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from wyli and Nic-Ma September 17, 2021 16:21
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Sep 17, 2021

Hi @rijobro ,

I am checking the left transforms, seems these 4 intensity transforms already execute with Tensor data, but the code stype doesn't follow our backend design:
"GibbsNoise",
"RandGibbsNoise",
"KSpaceSpikeNoise",
"RandKSpaceSpikeNoise",
Do you also plan to add backend support for them in v0.7?

Thanks in advance.

@rijobro
Copy link
Contributor Author

rijobro commented Sep 17, 2021

Sure, I'll do them on Monday.

@rijobro
Copy link
Contributor Author

rijobro commented Sep 23, 2021

hi @wyli I'm struggling to replicate the problems in this PR locally. I've tried with pytorch 1.6 and 1.7, with cuda toolkit 11.0 and 10.2, to no avail. Any ideas? https://github.com/Project-MONAI/MONAI/pull/2971/checks?check_run_id=3673884529

Edit: managed to replicate, thanks.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
s
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro enabled auto-merge (squash) September 24, 2021 14:34
@rijobro rijobro merged commit 453a9c0 into Project-MONAI:dev Sep 24, 2021
@rijobro rijobro deleted the torch_gaussian_smooth_sharpen branch September 27, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants