Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant noqa #3027

Merged
merged 6 commits into from
Oct 3, 2021
Merged

remove redundant noqa #3027

merged 6 commits into from
Oct 3, 2021

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Sep 24, 2021

Description

enable hook which is removing noqa notations which are not needed anymore

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Borda Borda marked this pull request as draft September 24, 2021 22:50
@Borda Borda mentioned this pull request Sep 30, 2021
Closed
@Borda Borda force-pushed the yesqa branch 3 times, most recently from 4c068a8 to 688c106 Compare September 30, 2021 16:09
@Borda Borda marked this pull request as ready for review September 30, 2021 17:10
@Borda
apply yesqa
eefecde 
Signed-off-by: Jirka <jirka.borovec@seznam.cz>
@Borda
rev
8ba78a2 
Signed-off-by: Jirka <jirka.borovec@seznam.cz>
@Borda
expand
60aa552 
Signed-off-by: Jirka <jirka.borovec@seznam.cz>
@Borda
plugins
b109705 
Signed-off-by: Jirka <jirka.borovec@seznam.cz>
@Borda
Copy link
Contributor Author

Borda commented Oct 3, 2021

@wyli mind have look?

wyli
wyli approved these changes Oct 3, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me.

@wyli wyli merged commit 8271d8e into Project-MONAI:dev Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @wyli