-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra transform examples #3056
Extra transform examples #3056
Conversation
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
for more information, see https://pre-commit.ci
@wyli I tried modifying the docs/conf.py to include this: # If there is a + in the version, that means that we're not on a tagged version.
# In this case, we'll use the URL to the `main` branch. If we're on a clean version,
# then use that tag.
if "+" in monai.__version__:
doc_image_url = "https://github.com/Project-MONAI/DocImages/raw/main/"
else:
doc_image_url = "https://raw.githubusercontent.com/Project-MONAI/DocImages/" + monai.__version__ + "/"
rst_epilog = f"""
.. |DocImageURL| replace:: {doc_image_url}
""" and then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the great work here!
I checked the preview, it looks fantastic.
I have some minor comments:
- The example of
RandCropByPosNegLabel
seems not correct(it's not 8 samples, and why some black regions?):
- Could you please also add example image to
KeepLargestConnectedComponent
? I think it's an important transform and not very straight-forward for users.
Thanks.
BTW, maybe I missed some context discussion, may I know why the Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, it looks good to me.
@Nic-Ma I used colour for the dictionary transforms because they have the segmentations overlayed. The underlying MR image is black and white in both cases. Let me know if you find it unclear and we can discuss something better. |
@Nic-Ma , and you're right. There's something wrong with all the num_samples=8, I'll check that. |
Got it, thanks! |
Sure, please also take a look other Thanks. |
Description
Adds the majority of examples for transforms.
new transforms.html can be seen here (I had to add the .txt extension, so remove that):
https://github.com/Project-MONAI/MONAI/files/7266593/transforms.html.txt
Alternatively, you can see the images (out of context) here:
https://github.com/Project-MONAI/DocImages/tree/main/transforms
Status
Ready
Types of changes
make html
command in thedocs/
folder.