Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong doc-strings in several handlers #3109

Merged
merged 8 commits into from
Oct 12, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Oct 12, 2021

Description

Thanks for the feedback from internal team, this PR fixed outdated doc-strings in several handlers, especially the wrong item engine.state.log.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma force-pushed the fix-handler-doc-string branch from 07f2f36 to ae9d75e Compare October 12, 2021 03:18
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 12, 2021

/black

@wyli
Copy link
Contributor

wyli commented Oct 12, 2021

/build

@Nic-Ma Nic-Ma requested a review from yiheng-wang-nv October 12, 2021 11:44
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) October 12, 2021 12:07
@wyli wyli disabled auto-merge October 12, 2021 12:47
@wyli wyli merged commit 712d90b into Project-MONAI:dev Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants