Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3114 Add fast training integration test #3120

Merged
merged 11 commits into from
Oct 14, 2021
Merged

3114 Add fast training integration test #3120

merged 11 commits into from
Oct 14, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Oct 13, 2021

Fixes #3114 .

Description

This PR added integration test for our fast training solution with synthetic data.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 13, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 13, 2021

/integration-test

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 13, 2021 11:13
@Nic-Ma
[DLMED] add more random test
f35099d 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 14, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 14, 2021

/integration-test

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 14, 2021

/build

@wyli
Copy link
Contributor

wyli commented Oct 14, 2021

looks like some errors from the latest integration? https://github.com/Project-MONAI/MONAI/runs/3890077106?check_suite_focus=true

@Nic-Ma Nic-Ma requested a review from wyli October 14, 2021 16:06
@wyli
Copy link
Contributor

wyli commented Oct 14, 2021 •
edited
Loading

/integration-test
/build

wyli
wyli approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it passes the integration tests.

@wyli wyli merged commit 6dc65db into Project-MONAI:dev Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

integration tests for the fast training tutorials
2 participants
@Nic-Ma @wyli