Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3122 pytorch versions tests #3123

Merged
merged 5 commits into from
Oct 14, 2021
Merged

3122 pytorch versions tests #3123

merged 5 commits into from
Oct 14, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Oct 13, 2021

Fixes #3122

Description

  • split tests into quick normal and min.
  • adds more min. tests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

wyli added 4 commits October 13, 2021 18:51
@wyli
adds new tests
fee550d 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp tests
bd99a6f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes the tests
7e70316 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
split yml
93bfdd9 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from ericspod, Nic-Ma and rijobro October 13, 2021 19:50
@wyli
Copy link
Contributor Author

wyli commented Oct 13, 2021 •
edited
Loading

/build

new set of tests work fine: https://github.com/Project-MONAI/MONAI/actions/runs/1339024120

@wyli wyli marked this pull request as ready for review October 13, 2021 22:15
ericspod
ericspod approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one fix good to go.

@wyli
fixes typo
d1c6268 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 14, 2021

/build

@wyli wyli enabled auto-merge (squash) October 14, 2021 08:32
@wyli wyli merged commit c4dd43f into dev Oct 14, 2021
@wyli wyli deleted the 3122-pytorch-versions-tests branch October 14, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quick permerge tests for different torch versions
2 participants
@wyli @ericspod