Skip to content

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Oct 15, 2021

Fixes #3134

Description

  • removed the conflicting aliases
  • renamed module monai.utils.deprecated to monai.utils.deprecated_utils because there's a function defined for monai.utils.deprecated.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.

wyli added 8 commits October 15, 2021 13:11
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good on me.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 15, 2021

/build

1 similar comment
@wyli
Copy link
Contributor Author

wyli commented Oct 15, 2021

/build

@wyli
Copy link
Contributor Author

wyli commented Oct 15, 2021

/build

@wyli wyli merged commit 0a9d8aa into Project-MONAI:dev Oct 15, 2021
@wyli wyli deleted the fixes-alias branch October 15, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Network alias is conflicting with the module names

2 participants