Skip to content

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Oct 15, 2021

Description

Hi @rijobro , the PR #3079 added Tensor support to 3 transforms, but I think it missed to add Tensor support to the dict version CropForegroundd, this PR added it.
And also fixed minor issue in dtype_conversion for list[GPU tensor, GPU tensor], and enhanced some data conversion.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 15, 2021

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the dict-cropforeground branch from b40f948 to 384040b Compare October 15, 2021 17:42
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 15, 2021 17:43
@Nic-Ma Nic-Ma changed the title [WIP] Add Tensor support to CropForegroundd transform Add Tensor support to CropForegroundd transform Oct 15, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review October 15, 2021 17:43
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 15, 2021

/build

@wyli
Copy link
Contributor

wyli commented Oct 17, 2021

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 18, 2021

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) October 18, 2021 08:49
@wyli
Copy link
Contributor

wyli commented Oct 19, 2021

/build

@Nic-Ma Nic-Ma merged commit 6938313 into Project-MONAI:dev Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants