Skip to content

3159 adds a default util logger#3160

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
wyli:3159-logger
Oct 23, 2021
Merged

3159 adds a default util logger#3160
wyli merged 3 commits intoProject-MONAI:devfrom
wyli:3159-logger

Conversation

@wyli
Copy link
Contributor

@wyli wyli commented Oct 20, 2021

Fixes #3159

Description

adds a default logger to monai.apps.utils

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro October 20, 2021 21:18
@wyli wyli marked this pull request as ready for review October 20, 2021 21:36
@wyli
Copy link
Contributor Author

wyli commented Oct 21, 2021

/build

@ericspod
Copy link
Member

Looks good, something wrong with blossom?

@wyli
Copy link
Contributor Author

wyli commented Oct 21, 2021

Looks good, something wrong with blossom?

it was blocked by #3165

wyli added 3 commits October 23, 2021 16:15
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Oct 23, 2021

/build

@wyli wyli enabled auto-merge (squash) October 23, 2021 15:31
@wyli
Copy link
Contributor Author

wyli commented Oct 23, 2021

/build

@wyli wyli merged commit 7964d45 into Project-MONAI:dev Oct 23, 2021
@wyli wyli deleted the 3159-logger branch November 16, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

load_mmar prints lots of information on console

3 participants