Skip to content

3142 Add backend to utility transforms #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nic-Ma merged 13 commits into from
Oct 26, 2021
Merged

3142 Add backend to utility transforms #3186

Nic-Ma merged 13 commits into from
Oct 26, 2021

Conversation

@Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Oct 26, 2021 •
edited
Loading

Fixes #3142 .

Description

This PR is follow up of #3142 , added backend to the utility transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title [WIP] 3142 Add backend to utility transforms 3142 Add backend to utility transforms Oct 26, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review October 26, 2021 04:17
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 26, 2021 04:18
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 26, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 26, 2021

/build

wyli
wyli reviewed Oct 26, 2021
View reviewed changes
Nic-Ma and others added 2 commits October 26, 2021 19:53
@Nic-Ma
[DLMED] add more tests
dbf6e79 
Signed-off-by: Nic Ma <nma@nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
a6f521a 
for more information, see https://pre-commit.ci
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 26, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 26, 2021

/build

@Nic-Ma Nic-Ma requested a review from wyli October 26, 2021 11:54
@monai-bot
[MONAI] python code formatting
a743a2c 
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Oct 26, 2021

/build

wyli
wyli approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Contributor

wyli commented Oct 26, 2021

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) October 26, 2021 15:23
@Nic-Ma Nic-Ma merged commit 65c253e into Project-MONAI:dev Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Some transforms randomly output numpy or tensor that can't collate

3 participants

@Nic-Ma @wyli @monai-bot