Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2231 adds backend for largest cc #3239

Merged
merged 3 commits into from
Nov 3, 2021
Merged

2231 adds backend for largest cc #3239

merged 3 commits into from
Nov 3, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 2, 2021 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #2231

Description

adds a backend for keeplargestconnectedcomponent

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the backend-keeplargecomponent branch from 417aa6e to 1aac0c8 Compare November 2, 2021 14:03
@wyli
Copy link
Contributor Author

wyli commented Nov 2, 2021

/integration-test

@wyli
Copy link
Contributor Author

wyli commented Nov 2, 2021

/black

@wyli
adds backend for largest cc
51028f1 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the backend-keeplargecomponent branch from 1aac0c8 to 51028f1 Compare November 2, 2021 14:14
@wyli
compatibility
26261bf 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review November 2, 2021 16:54
@wyli
Copy link
Contributor Author

wyli commented Nov 2, 2021

/build

Nic-Ma
Nic-Ma approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the enhancement.
Looks good to me.

@wyli
Copy link
Contributor Author

wyli commented Nov 3, 2021

/build

@wyli wyli enabled auto-merge (squash) November 3, 2021 09:23
@wyli wyli merged commit 547830b into Project-MONAI:dev Nov 3, 2021
@wyli wyli deleted the backend-keeplargecomponent branch November 3, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
transform usability/ Default to use t...
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @Nic-Ma