-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smooth field #3252
Smooth field #3252
Conversation
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
/black |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Please note to add an example image in the doc: https://github.com/Project-MONAI/DocImages Thanks. |
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Thanks, I was going to ask about the image docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good once some of the suggested changes are incorporated. As you say, more tests needed, too.
For the image docs, you need to:
|
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
Signed-off-by: Eric Kerfoot <eric.kerfoot@kcl.ac.uk>
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me.
Description
This adds a few transforms that use a smooth field to adjust contrast and intensity over regions of an input image rather than for the whole image. This is useful for simulating different acquisition qualities in MR images. This isn't finished yet with more and better tests needed and @rijobro to look over to see what needs to be changed to be more compatible with the push for Pytorch+Numpy hybrid transforms.
This adds a new transform directory for these, perhaps others should be added for MR-specific transforms and other groupings to reduce the size of the
array.py
/dictionary.py
files that currently exist.Status
Work in progress
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.