Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3276 - adds an option to skip renorm #3277

Merged
merged 7 commits into from
Nov 8, 2021
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 6, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3276
Fixes #3283

Description

if the target range is none, skipping the renorm

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 3 commits November 7, 2021 09:22
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 7, 2021

/build

@wyli wyli marked this pull request as ready for review November 7, 2021 11:45
wyli and others added 3 commits November 8, 2021 10:19
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Nov 8, 2021

/build

@wyli wyli enabled auto-merge (squash) November 8, 2021 11:46
@wyli wyli disabled auto-merge November 8, 2021 12:23
@wyli wyli enabled auto-merge (squash) November 8, 2021 12:28
@wyli wyli merged commit 8c0ff37 into Project-MONAI:dev Nov 8, 2021
@wyli wyli deleted the 3276-skip-norm branch November 16, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_cachedataset_persistent_workers freeze randomly for pytorch:21.09 ScaleIntesityRange performance
2 participants