Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tifffile support in WSIReader #3278

Merged
merged 14 commits into from
Nov 11, 2021
Merged

Conversation

bhashemian
Copy link
Member

@bhashemian bhashemian commented Nov 6, 2021

Fixes #3251

Description

This PR adds support for tifffile in WSIReader to read TIFF files (which is common in histopathology whole slide imaging). While cucim and openslide both can load patches from large whole slide images without loading the entire image into memory, tifffile loads the entire image into before extracting any patch. Thus memory consideration is needed when using tifffile for patch extraction.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian requested review from wyli and Nic-Ma November 6, 2021 23:24
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian
Copy link
Member Author

@Nic-Ma could you please take a look at this and run /build here?

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 8, 2021

/build

monai/data/image_reader.py Show resolved Hide resolved
monai/data/image_reader.py Outdated Show resolved Hide resolved
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for the update.

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 11, 2021 02:26
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 11, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 11, 2021

/build

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 11, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 11, 2021

/build

@Nic-Ma Nic-Ma merged commit cfe64aa into Project-MONAI:dev Nov 11, 2021
@bhashemian bhashemian deleted the tifffile-support branch November 23, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tifffile support in WSIReader
3 participants