Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3284 torch version check #3285

Merged
merged 17 commits into from
Nov 12, 2021
Merged

3284 torch version check #3285

merged 17 commits into from
Nov 12, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 7, 2021 •
edited
Loading

Fixes #3284

Description

Adds a utility to identify PyTorch versions

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 4 commits November 7, 2021 13:28
@wyli
torch version check
17c19bd 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp tests
3171f6b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
additional cases
001bade 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes tests
67842d8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the torch-version-check branch from c5a01e0 to 67842d8 Compare November 7, 2021 22:08
@wyli
update unit test names
5cc18ec 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 8, 2021

/build

wyli added 2 commits November 8, 2021 14:33
@wyli
Merge remote-tracking branch 'upstream/dev' into torch-version-check
39e8b1f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove temp tests
5fa7715 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review November 8, 2021 14:34
@wyli
Copy link
Contributor Author

wyli commented Nov 8, 2021

/integration-test

@wyli wyli requested review from Nic-Ma and ericspod November 10, 2021 15:01
@wyli
update based on comments
9b191df 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the torch-version-check branch from 5485c12 to 9b191df Compare November 10, 2021 17:31
wyli added 3 commits November 10, 2021 20:10
@wyli
fixes codeformat
0d053e3 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge branch 'dev' into torch-version-check
eb03609 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Merge branch 'dev' into torch-version-check
49dc3f6
@wyli wyli requested a review from ericspod November 11, 2021 00:32
@wyli
Copy link
Contributor Author

wyli commented Nov 12, 2021

could you review this? @Nic-Ma @ericspod

@wyli
Copy link
Contributor Author

wyli commented Nov 12, 2021

/build

@wyli wyli enabled auto-merge (squash) November 12, 2021 16:42
@wyli wyli merged commit e148cfd into dev Nov 12, 2021
@wyli wyli deleted the torch-version-check branch November 12, 2021 17:27
@wyli wyli added this to the Backward compatibility [P0] milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericspod ericspod ericspod approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backward compatibility [P0]
Development

Successfully merging this pull request may close these issues.

pytorch version utility
2 participants
@wyli @ericspod