-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3329 compatibility with pathlike obj #3332
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyli
force-pushed
the
3329-fixes-path
branch
from
November 14, 2021 11:44
16f4f1f
to
e32444c
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
3329-fixes-path
branch
from
November 14, 2021 21:58
e32444c
to
129c7ee
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
3329-fixes-path
branch
from
November 15, 2021 15:08
a0da721
to
09661d9
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
3329-fixes-path
branch
from
November 15, 2021 16:32
09661d9
to
dbb3d0f
Compare
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
3329-fixes-path
branch
from
November 15, 2021 18:56
d5e5151
to
6926dc3
Compare
/integration-test |
/build |
Nic-Ma
approved these changes
Nov 16, 2021
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
force-pushed
the
3329-fixes-path
branch
from
November 16, 2021 11:51
aa05552
to
22db84e
Compare
/build |
1 similar comment
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #3329
Description
review and enhance the support of pathlib related objects.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.