Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3329 compatibility with pathlike obj #3332

Merged
merged 12 commits into from
Nov 16, 2021
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 14, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3329

Description

review and enhance the support of pathlib related objects.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 5 commits November 15, 2021 12:01
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 2 commits November 15, 2021 16:32
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 15, 2021

/integration-test

@wyli
Copy link
Contributor Author

wyli commented Nov 15, 2021

/build

@wyli wyli marked this pull request as ready for review November 15, 2021 22:48
@wyli wyli requested review from Nic-Ma, rijobro and ericspod and removed request for Nic-Ma November 15, 2021 22:48
monai/apps/datasets.py Show resolved Hide resolved
wyli added 2 commits November 16, 2021 10:39
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 16, 2021

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 16, 2021

/build

1 similar comment
@wyli
Copy link
Contributor Author

wyli commented Nov 16, 2021

/build

@wyli wyli merged commit 4c2c1dc into Project-MONAI:dev Nov 16, 2021
@wyli wyli deleted the 3329-fixes-path branch November 16, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download_and_extract to handle Path objects and downloaded file auto naming
2 participants