Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3331 SegresnetVAE to use the base class APIs #3334

Merged
merged 2 commits into from
Nov 15, 2021
Merged

3331 SegresnetVAE to use the base class APIs #3334

merged 2 commits into from
Nov 15, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 14, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3331

Description

  • update segresnetVAE to use the base API
  • fixes act

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
fixes Project-MONAI#3331
0fe7492 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title fixes #3331 SegresnetVAE to use the base class APIs 3331 SegresnetVAE to use the base class APIs Nov 14, 2021
@wyli wyli requested a review from Nic-Ma November 14, 2021 22:34
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 15, 2021

Hi @yiheng-wang-nv @myron ,

Could you please help review this PR?

Thanks in advance.

@wyli
Copy link
Contributor Author

wyli commented Nov 15, 2021

/build

@wyli wyli enabled auto-merge (squash) November 15, 2021 13:54
@wyli wyli merged commit 8a454bd into Project-MONAI:dev Nov 15, 2021
@myron
Copy link
Collaborator

myron commented Nov 15, 2021

i think if it's just a syntax change, it should be ok

@wyli wyli deleted the 3331-segresnet branch November 18, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@ericspod ericspod Awaiting requested review from ericspod

@rijobro rijobro Awaiting requested review from rijobro

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wyli @Nic-Ma @myron @yiheng-wang-nv