Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3335 update clang-format download #3340

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 15, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3335

Description

update based on the recent pytorch codebase changes and pytorch PR 68292

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro November 15, 2021 08:30
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3335-update-clang-format branch from 2b40977 to 2cb0c1e Compare November 15, 2021 08:38
@wyli wyli mentioned this pull request Nov 15, 2021
7 tasks
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 15, 2021

/build

monai/apps/utils.py Show resolved Hide resolved
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 15, 2021

/build

@wyli wyli enabled auto-merge (squash) November 15, 2021 12:33
@wyli wyli merged commit af21f11 into Project-MONAI:dev Nov 15, 2021
@wyli wyli deleted the 3335-update-clang-format branch November 18, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit test error from python -m tests.clang_format_utils
2 participants