Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3350 drops pytorch 1.5.x support #3353

Merged
merged 4 commits into from
Nov 18, 2021
Merged

3350 drops pytorch 1.5.x support #3353

merged 4 commits into from
Nov 18, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 17, 2021 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #3350

Description

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested a review from Nic-Ma November 17, 2021 12:07
@wyli
drop pytorch 1.5.x
86f5684 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3350-drop-pytorch-1.5 branch from f95284a to 86f5684 Compare November 17, 2021 12:16
@wyli
Copy link
Contributor Author

wyli commented Nov 17, 2021

/build

@wyli
update premerge gpu
1ad89be 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3350-drop-pytorch-1.5 branch from 3e2a91d to 1ad89be Compare November 17, 2021 12:49
@wyli
Copy link
Contributor Author

wyli commented Nov 17, 2021

/build

1 similar comment
@wyli
Copy link
Contributor Author

wyli commented Nov 17, 2021

/build

Nic-Ma
Nic-Ma reviewed Nov 17, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wyli ,

Could you please help also drop this kind of lines:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/utils.py#L1313
If you don't plan to change these torch APIs in this PR, I can help do it soon.

Thanks.

.github/workflows/pythonapp-gpu.yml Show resolved Hide resolved
@wyli
update based on comments
ee8fd2d 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3350-drop-pytorch-1.5 branch from 60f5959 to 5ecf03e Compare November 18, 2021 09:53
@wyli
Copy link
Contributor Author

wyli commented Nov 18, 2021

Hi @wyli ,

Could you please help also drop this kind of lines: https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/utils.py#L1313 If you don't plan to change these torch APIs in this PR, I can help do it soon.

Thanks.

thanks, updated the PR to remove hasattr(torch, "searchsorted"), the other checks look necessary. once this is merged we can check the code coverage report to remove the necessary ones.

@wyli
Merge branch 'dev' into 3350-drop-pytorch-1.5
ac80a8f 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3350-drop-pytorch-1.5 branch from 5ecf03e to ac80a8f Compare November 18, 2021 09:58
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 18, 2021

Hi @wyli ,
Could you please help also drop this kind of lines: https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/utils.py#L1313 If you don't plan to change these torch APIs in this PR, I can help do it soon.
Thanks.

thanks, updated the PR to remove hasattr(torch, "searchsorted"), the other checks look necessary. once this is merged we can check the code coverage report to remove the necessary ones.

Sure, sounds good to me.
I already manually checked several hasattr(torch, "XXX") in PyTorch 1.5.1, not much need to update I think.

Thanks.

@wyli
Copy link
Contributor Author

wyli commented Nov 18, 2021

/build

@wyli wyli enabled auto-merge (squash) November 18, 2021 11:20
@wyli wyli merged commit 2e83cd2 into Project-MONAI:dev Nov 18, 2021
@wyli wyli deleted the 3350-drop-pytorch-1.5 branch November 18, 2021 22:18
@Shadow-Devil Shadow-Devil mentioned this pull request Nov 28, 2022
Merged
1 task
wyli pushed a commit to Project-MONAI/tutorials that referenced this pull request Nov 28, 2022
@Shadow-Devil
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) (#1072)
85d441b 
Fixes #509

### Description
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) because
the core codebase now requires at least torch 1.6. See also
[here](Project-MONAI/MONAI#3353)

### Checks
- [x] Notebook runs automatically `./runner [-p <regex_pattern>]`
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
@Shadow-Devil
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) (Projec…
3bfdea9 
…t-MONAI#1072)

Fixes Project-MONAI#509

### Description
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) because
the core codebase now requires at least torch 1.6. See also
[here](Project-MONAI/MONAI#3353)

### Checks
- [x] Notebook runs automatically `./runner [-p <regex_pattern>]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @Nic-Ma