Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dynunetv1 blocks #3360

Merged
merged 2 commits into from
Nov 18, 2021
Merged

remove dynunetv1 blocks #3360

merged 2 commits into from
Nov 18, 2021

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 18, 2021 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

follow-up of #3265

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
remove dynunetv1 blocks
7c6b15d 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Nic-Ma
Nic-Ma approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Please double confrm to remove all the other DynUNet v1 related things.
@yiheng-wang-nv please also help review it.

Thanks in advance.

@wyli
Copy link
Contributor Author

wyli commented Nov 18, 2021

/build

@wyli wyli enabled auto-merge (squash) November 18, 2021 17:37
@wyli wyli merged commit f7e4cc3 into Project-MONAI:dev Nov 18, 2021
@wyli wyli deleted the deprecate-dynunetv1 branch November 18, 2021 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @Nic-Ma