Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3370 option of zip_longest to decollate #3373

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Nov 19, 2021

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3370

Description

defaults to pad the to batch data to be decollated when the items suggest different batch sizes.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Sorry, something went wrong.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 4 commits November 20, 2021 01:40
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro November 20, 2021 15:18
@wyli wyli marked this pull request as ready for review November 20, 2021 15:18
@wyli
Copy link
Contributor Author

wyli commented Nov 20, 2021

/build

@wyli wyli requested a review from Nic-Ma November 21, 2021 13:27
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Nov 21, 2021

/build

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 21, 2021

/integration-test

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 21, 2021

Hi @wyli ,

Seems /integration-test doesn't work properly?
Let's try to run integration tests to double confirm it.

Thanks.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 22, 2021

/integration-test

@wyli wyli merged commit 37930a9 into Project-MONAI:dev Nov 22, 2021
@wyli wyli deleted the zip-longest branch November 22, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

decollate_batch return an empty list
2 participants