-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3368 add frame_dim
to TensorBoard plot utility
#3385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
/build |
1 similar comment
/build |
I also tested the Thanks. |
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
/build |
wyli
reviewed
Nov 23, 2021
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
/build |
wyli
approved these changes
Nov 24, 2021
/build |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3368 .
Description
This PR mainly contains 4 parts:
frame_dim
to plot the GIF image or RGB video in TensorBoard, similar to 3368 Addframe_dim
to specify the dim as frames of visualization #3369 .add_animated_gif_no_channels
as the input data shape actually doesn't work withmake_animated_gif_summary
and no place really calls this API. I think it was ported from other codebase by mistake.animation_axes
andimage_axes
args from the private function. They are actually not used(already declared in the doc-string before).Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.