Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3368 add frame_dim to TensorBoard plot utility #3385

Merged
merged 11 commits into from
Nov 25, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Nov 23, 2021

Fixes #3368 .

Description

This PR mainly contains 4 parts:

  1. Added support to specify frame_dim to plot the GIF image or RGB video in TensorBoard, similar to 3368 Add frame_dim to specify the dim as frames of visualization #3369 .
  2. Removed add_animated_gif_no_channels as the input data shape actually doesn't work with make_animated_gif_summary and no place really calls this API. I think it was ported from other codebase by mistake.
  3. Removed the animation_axes and image_axes args from the private function. They are actually not used(already declared in the doc-string before).
  4. Added some missing doc-strings.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

/build

1 similar comment
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

Hi @ericspod @wyli ,

I also tested the frame_dim parameter in the tutorial:
https://github.com/Project-MONAI/tutorials/blob/master/modules/transform_visualization.ipynb
The output GIF image is as expected.
In this PR, the default frame dim is -3, same as matshpw3d() now.

Thanks.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 23, 2021

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Nov 24, 2021

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 25, 2021 00:13
@Nic-Ma Nic-Ma merged commit a640dde into Project-MONAI:dev Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add frame_dim to the matshow3d utility
2 participants