3405 Enhance doc-string of MIL model for data shape #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
Nic-Ma
requested review from
bhashemian,
myron,
ericspod,
wyli and
yiheng-wang-nv
Signed-off-by: Nic Ma <nma@nvidia.com>
yiheng-wang-nv
approved these changes
Nov 26, 2021
|
/build |
wyli
reviewed
Nov 26, 2021
| @@ -11,6 +11,10 @@ | |||
| class MILModel(nn.Module): | |||
| """ | |||
| Multiple Instance Learning (MIL) model, with a backbone classification model. | |||
| Currently, it only works for 2D images, typical use case is for classification of the | |||
There was a problem hiding this comment.
looks like this model will be 2D only, the name MILModel is too generic and confusing cc @myron
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3405 .
Description
This PR enhanced doc-string of MIL model to help users understand the expected data shape, like #3405 .
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.