-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3402 Add support to set other pickle related args #3412
Conversation
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
I added unit tests to cover the args, and also verified with the below program to cache big content with train_transforms = Compose(
[
LoadImaged(keys=["image", "label"]),
AddChanneld(keys=["image", "label"]),
Spacingd(keys=["image", "label"], pixdim=(0.5, 0.5, 0.5), mode=("bilinear", "nearest")),
RepeatChanneld(keys="image", repeats=3),
EnsureTyped(keys=["image", "label"]),
]
) Thanks. |
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
48f8bb9
to
89c6bd8
Compare
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
c4a9ccc
to
980ee78
Compare
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Some CI lib may be updated so the flake8 test failed in
I slightly adjusted the document of Thanks. |
/black |
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me apart from the minor issue.
Signed-off-by: Nic Ma <nma@nvidia.com>
/build |
/build |
Fixes #3402 .
Description
This PR added support to set other pickle related args for
torch.save
, especially for big cache content as user requested in #3402 .Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.