Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3392 enhance reduction doc-string for Nan values #3424

Merged
merged 7 commits into from
Dec 1, 2021
Merged

3392 enhance reduction doc-string for Nan values #3424

merged 7 commits into from
Dec 1, 2021

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Dec 1, 2021 •
edited
Loading

Fixes #3392 .

Description

This PR enhanced the doc-string of reduction in metrics for the Nan values.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 1, 2021

/black

@yiheng-wang-nv
Copy link
Contributor

Thanks Nic, the updates look good on me.

@Nic-Ma Nic-Ma changed the title [WIP] 3392 enhance reduction doc-string for Nan values 3392 enhance reduction doc-string for Nan values Dec 1, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review December 1, 2021 10:13
@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 1, 2021

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) December 1, 2021 10:14
@Nic-Ma Nic-Ma merged commit fc9abb9 into Project-MONAI:dev Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nic-Ma @yiheng-wang-nv