-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3482 Build component instance from dictionary config #3518
3482 Build component instance from dictionary config #3518
Conversation
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
/build |
1 similar comment
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
/black |
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems this is not compatible with the lazy instantiation idea, perhaps we should agree on a proof-of-concept before writing small pull requests.
Hi @wyli , Thanks for your review and feedback. Thanks. |
/black |
5f11e8e
to
87495ef
Compare
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
87495ef
to
b925f27
Compare
/black |
/build |
Maybe there's a misunderstanding here, the lazy instantiation will work at the component level as well. Also, it'll be useful to have a complete prototype and then we divide it into smaller pieces and merge. That'll be an efficient way to roll out a major feature. |
OK, sounds good to me. Thanks. |
Task 2 of #3482 .
Description
This PR implemented the utility to build a component instance from dictionary config, searching from specified packages and modules.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests
.make html
command in thedocs/
folder.