Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3628 0-d array to_contiguous #3629

Merged
merged 2 commits into from
Jan 10, 2022
Merged

3628 0-d array to_contiguous #3629

merged 2 commits into from
Jan 10, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 10, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3628

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
0-d array
78f3ea3 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jan 10, 2022

/integration-test

@wyli
handling string types
d8baac2 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Copy link
Contributor Author

wyli commented Jan 10, 2022

/integration-test

@wyli
Copy link
Contributor Author

wyli commented Jan 10, 2022

/build

@wyli wyli marked this pull request as ready for review January 10, 2022 13:41
@wyli
Copy link
Contributor Author

wyli commented Jan 10, 2022

/build

@wyli wyli enabled auto-merge (squash) January 10, 2022 14:33
@wyli wyli merged commit 3c6ee69 into Project-MONAI:dev Jan 10, 2022
@wyli wyli deleted the fixes-contiguous branch January 10, 2022 14:40
wyli added a commit that referenced this pull request Jan 10, 2022
@wyli
3628 0-d array to_contiguous (#3629)
5807f5d 
* 0-d array

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* handling string types

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to contiguous of 0-dim array
2 participants
@wyli @Nic-Ma