Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3631 update temp window tests #3633

Merged
merged 1 commit into from
Jan 11, 2022
Merged

3631 update temp window tests #3633

merged 1 commit into from
Jan 11, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 10, 2022 •
edited
Loading

Signed-off-by: Wenqi Li wenqil@nvidia.com

fixes #3613

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Contributor Author

wyli commented Jan 10, 2022

/build

@wyli wyli force-pushed the temp-fix-windows-test branch from d4a57d6 to 116edbf Compare January 10, 2022 23:29
@wyli
capture windows permission error
d676595 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the temp-fix-windows-test branch from 8c65aa1 to d676595 Compare January 11, 2022 00:09
@wyli wyli requested a review from Nic-Ma January 11, 2022 00:09
@wyli wyli marked this pull request as ready for review January 11, 2022 00:09
@wyli
Copy link
Contributor Author

wyli commented Jan 11, 2022

/build

1 similar comment
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jan 11, 2022

/build

Nic-Ma
Nic-Ma approved these changes Jan 11, 2022
View reviewed changes
monai/data/dataset.py Show resolved Hide resolved
@wyli wyli mentioned this pull request Jan 11, 2022
Closed
@wyli
Copy link
Contributor Author

wyli commented Jan 11, 2022

/build

@wyli wyli enabled auto-merge (squash) January 11, 2022 09:37
@wyli wyli merged commit 83f8b06 into Project-MONAI:dev Jan 11, 2022
@wyli wyli deleted the temp-fix-windows-test branch January 11, 2022 11:14
wyli added a commit that referenced this pull request Jan 21, 2022
@wyli
capture windows permission error (#3633)
a151ca8 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_persistentdataset_dist error on windows
2 participants
@wyli @Nic-Ma