Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3578 Support single channel with OneHot format in KeepLargestConnectedComponents #3647

Merged
merged 10 commits into from
Jan 13, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Jan 12, 2022

Fixes #3578 .

Description

Thanks for @function2-llx feedback in #3578, this PR added support for the case that all the data are in OneHot format but some of them may only has 1 channel in KeepLargestConnectedComponents transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 12, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 12, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 12, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 12, 2022

/build

Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it looks good to me, we can add is_onehot=None to resume to the previous behaviour?

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 13, 2022

/black

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 13, 2022

/build

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Jan 13, 2022

thanks, it looks good to me, we can add is_onehot=None to resume to the previous behaviour?

Sure, updated in the latest commit.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) January 13, 2022 02:18
@Nic-Ma Nic-Ma merged commit cd177c0 into Project-MONAI:dev Jan 13, 2022
wyli pushed a commit that referenced this pull request Jan 14, 2022
…dComponents (#3647)

* [DLMED] support single channel One-Hot

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>
wyli pushed a commit that referenced this pull request Jan 21, 2022
…dComponents (#3647)

* [DLMED] support single channel One-Hot

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants