Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3654 remove some flake8 errors ignore #3659

Merged
merged 2 commits into from
Jan 14, 2022
Merged

3654 remove some flake8 errors ignore #3659

merged 2 commits into from
Jan 14, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 13, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

part of #3654

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro January 13, 2022 17:34
rijobro
rijobro approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks!

@wyli wyli mentioned this pull request Jan 13, 2022
Closed
wyli added 2 commits January 13, 2022 23:19
@wyli
ignore some flake8 errors
93f6f4d 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes Project-MONAI#3660 2003->2106
a8fbc70 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the less-ignore-flake8 branch from d857555 to a8fbc70 Compare January 13, 2022 23:20
@wyli
Copy link
Contributor Author

wyli commented Jan 13, 2022

/build

@wyli wyli enabled auto-merge (squash) January 13, 2022 23:52
@wyli wyli merged commit a8ff27c into Project-MONAI:dev Jan 14, 2022
wyli added a commit that referenced this pull request Jan 14, 2022
@wyli
3654 remove some flake8 errors ignore (#3659)
2a62b1e 
* ignore some flake8 errors

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes #3660 2003->2106

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli deleted the less-ignore-flake8 branch April 27, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rijobro rijobro rijobro approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wyli @rijobro