Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPU-enabled function "get_largest_connected_component_mask" #3677

Merged
merged 20 commits into from
Feb 11, 2022
Merged

Add GPU-enabled function "get_largest_connected_component_mask" #3677

merged 20 commits into from
Feb 11, 2022

Conversation

dongyang0122
Copy link
Collaborator

Fixes # .

Description

Add GPU-enabled function "get_largest_connected_component_mask" using cuCIM and CuPy.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Dong Yang added 2 commits January 18, 2022 10:34
update largest cc function
0ce72f0 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update largest cc function
9ae1ad0 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
@dongyang0122 dongyang0122 requested review from wyli and Nic-Ma January 18, 2022 17:39
@dongyang0122 dongyang0122 self-assigned this Jan 18, 2022
@wyli
Copy link
Contributor

wyli commented Jan 18, 2022

Hi Dong, could you help fix the unit tests, you can run them with command: python -m tests.test_keep_largest_connected_componentd, the errors are https://github.com/Project-MONAI/MONAI/runs/4858242672?check_suite_focus=true#step:7:19139

@dongyang0122
Copy link
Collaborator Author

Yes, working on it.

Dong Yang and others added 15 commits January 20, 2022 10:51
update largest cc function
be44761 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update largest cc function
66cd83a 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update largest cc function
da78635 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
9e7c8c2 
for more information, see https://pre-commit.ci
update largest cc function
b78ffc3 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update largest cc function
cfa39ed 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0d78cb4 
for more information, see https://pre-commit.ci
update largest cc function
be4ead3 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update largest cc function
47c4c21 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
@dongyang0122
Merge branch 'dev' into largestcc
141607a
update largest cc function
7dd0de7 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update largest cc function
07ecdd0 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update largest cc function
58c6b86 
Signed-off-by: Dong Yang <dongy@dongy-mlt.client.nvidia.com>
update repo
3b9ad1a 
Signed-off-by: dongy <dongy@nvidia.com>
@dongyang0122
Merge branch 'dev' into largestcc
e672316
@wyli
Copy link
Contributor

wyli commented Feb 11, 2022

/build

@wyli wyli enabled auto-merge (squash) February 11, 2022 19:21
wyli
wyli approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli disabled auto-merge February 11, 2022 19:42
@wyli wyli enabled auto-merge (squash) February 11, 2022 19:42
@wyli wyli merged commit e2fcb97 into Project-MONAI:dev Feb 11, 2022
@wyli wyli mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

@dongyang0122 dongyang0122

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dongyang0122 @wyli