Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove tensor-array conversion in Orientation #3687

Merged
merged 9 commits into from
Jan 21, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 20, 2022

Signed-off-by: Wenqi Li wenqil@nvidia.com

Description

non-breaking update to avoid tensor <-> ndarray conversion for the input image in Orientation transform

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma and rijobro January 20, 2022 14:57
@wyli wyli changed the title remove tensor-array conversion remove tensor-array conversion in Orientation Jan 20, 2022
wyli added 4 commits January 20, 2022 14:58
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
tests/test_orientation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

wyli added 2 commits January 20, 2022 17:44
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review January 20, 2022 19:41
@wyli
Copy link
Contributor Author

wyli commented Jan 20, 2022

/integration-test

Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for minor comment.

Thanks.

monai/transforms/spatial/array.py Outdated Show resolved Hide resolved
@wyli
Copy link
Contributor Author

wyli commented Jan 21, 2022

/build

@wyli wyli enabled auto-merge (squash) January 21, 2022 11:56
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jan 21, 2022

Thanks for the quick update.
I think it looks good to me.
I am not very familiar with medical orientation computation, @ericspod @rijobro could you please help double confirm?

Thanks in advance.

@wyli wyli merged commit 25ecc28 into Project-MONAI:dev Jan 21, 2022
wyli added a commit that referenced this pull request Feb 9, 2022
* remove tensor-array convertions

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update backend

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update tests, remove meshgrid warnings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes typing issue

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes import

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Feb 9, 2022
* remove tensor-array convertions

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update backend

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update tests, remove meshgrid warnings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes typing issue

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes import

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Feb 9, 2022
* remove tensor-array convertions

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update backend

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update tests, remove meshgrid warnings

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes typing issue

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes import

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli deleted the improve-orientation branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants