3734 Enhance CacheDataset to avoid duplicated cache
#3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge master
merge master
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/build |
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/build |
wyli
reviewed
Jan 29, 2022
Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma
force-pushed
the
3734-add-hashid-cache
branch
from
e1b0ede to
b57a755
Compare
|
/black |
|
/build |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
|
/build |
|
Mark: Thanks. |
|
Sure, I'll separate the style changes into another style PR... |
Nic-Ma
changed the title
CacheDataset to avoid duplicated cache
|
/build |
wyli
reviewed
Jan 30, 2022
wyli
reviewed
Jan 30, 2022
wyli
reviewed
Jan 30, 2022
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
/build |
|
/build |
2 similar comments
|
/build |
|
/build |
wyli
approved these changes
Feb 1, 2022
|
/build |
|
/build |
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add HashCacheDataset Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] skip min test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add HashCacheDataset Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] skip min test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add HashCacheDataset Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] skip min test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* [DLMED] add HashCacheDataset Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] skip min test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3734 .
Description
This PR enhanced
CacheDatasetto avoid caching duplicated content for the augmented dataset.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.