Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update offset assign #3764

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Update offset assign #3764

merged 2 commits into from
Feb 4, 2022

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Feb 3, 2022

according to balbasty/nitorch#65

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, rijobro and ericspod February 3, 2022 18:09
@Nic-Ma Nic-Ma requested a review from charliebudd February 3, 2022 23:59
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Feb 3, 2022

Hi @charliebudd ,

Could you please help take a look at this PR for the C++ extension?

Thanks in advance.

charliebudd
charliebudd approved these changes Feb 4, 2022
View reviewed changes
Copy link
Collaborator

@charliebudd charliebudd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is more of an algorithmic change, and I'm unfamiliar with this algorithm. But nothing looks amiss to me.

wyli added 2 commits February 4, 2022 09:59
@wyli
update based on comments
dabc227 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
-Wmaybe-uninitialized
37e1428 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the update-offset-assign branch from fc55589 to 37e1428 Compare February 4, 2022 09:59
@wyli
Copy link
Contributor Author

wyli commented Feb 4, 2022

/build

@wyli wyli enabled auto-merge (squash) February 4, 2022 09:59
@wyli
Copy link
Contributor Author

wyli commented Feb 4, 2022

/build

@wyli wyli merged commit d050ea5 into Project-MONAI:dev Feb 4, 2022
@wyli wyli deleted the update-offset-assign branch February 4, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliebudd charliebudd charliebudd approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@rijobro rijobro Awaiting requested review from rijobro

@ericspod ericspod Awaiting requested review from ericspod

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wyli @Nic-Ma @charliebudd